Remove feedback from a provider
Withdraw a posted comment in the web app, or find every copy of a piece of feedback and delete it at the provider before an erasure or a purge.
Remove feedback from a provider when a comment that Hephaestus posted on the work must go, for example after wrong feedback. Start in the web app: it withdraws the comment and keeps a way back. Delete the comment at the provider only for an erasure, or when the web app cannot change the comment. Deleting data in Hephaestus does not delete a provider comment.
Before you start
- For a withdrawal in the web app, you are a workspace admin of the affected workspace.
- For a deletion at the provider, you are also an instance admin, and you have:
- Read-only access to the application database.
- Provider credentials that can delete the comments of the Hephaestus app, in a session apart from Hephaestus.
- A restricted incident record for the results.
Withdraw the comment in the web app
A workspace admin can withdraw feedback on the work in GitHub and GitLab.
Hephaestus edits each posted comment to say This feedback was withdrawn.
Silent mode also stops this edit.
If silent mode is on, check the comment again after you turn silent mode off.
- Open the review under Practices → Practice reviews → Reviews in the workspace administration.
- Choose the correction that fits:
- If the observation was wrong, select Mark incorrect on the observation. Give a reason, and confirm. Hephaestus withdraws each comment that rests on that observation.
- If the observation was right but the words were wrong, select Withdraw feedback on the feedback. Give a reason, and confirm.
- On the provider, open each comment.
It says
This feedback was withdrawn. - If a comment still shows the feedback, delete it at the provider, as the next sections describe. Do the same if the review says that the provider cannot correct the copy.
To undo a mark, select Remove mark. Hephaestus puts the original words back in the same comments, and posts nothing again. To undo a withdrawal, select Restore feedback. The feedback goes out again only after every check passes. Correct an observation and Withdraw feedback describe both corrections.
Slack messages and Hephaestus answers have no withdrawal. Delete them at the provider.
Finish the provider deletion before a workspace purge, a disconnect or a person erasure, because they remove the records that locate each copy.
Stop new copies
-
Turn on silent mode, as Contain an incident describes.
-
In the affected workspace, turn off Sending feedback → Send feedback (Feedback mode, review scope and delivery).
The workspace then sends nothing, also after silent mode is off.
Find every copy
-
Open the review in the web app, and note the workspace ID and the ID of the feedback.
-
List every copy of the feedback, without its text:
SELECT f.id, f.review_id, f.item_id, f.destination, f.state, f.replaces_id, p.id AS copy_id, p.kind, p.state AS copy_state, p.write_started_at, p.write_marker, p.external_ref, p.external_url, p.conversation_entry_id, p.conversation_turn_id, p.path, p.start_line, p.end_line, p.side, p.posted_at FROM feedback f LEFT JOIN feedback_copy p ON p.feedback_id = f.id AND p.workspace_id = f.workspace_id WHERE f.workspace_id = :'workspace_id'::bigint AND f.id = :'feedback_id'::uuid;Run it with
psql, with the variablesworkspace_idandfeedback_idset to the IDs of step 1. -
If
replaces_idis set, repeat step 2 for the replaced feedback. -
List the sends of the feedback:
SELECT kind, state, attempts, stop_reason FROM agent_action WHERE lane_key = 'feedback:' || :'feedback_id'; -
Treat each copy in the state
WRITE_STARTEDas a possible provider object, also without anexternal_ref. Do the same for each copy of a send that endedUNCERTAIN. -
For such a copy with a
write_marker, search the provider for the marker. Hephaestus appends it to the posted text. -
For a copy with a
conversation_entry_id, readconversation_id,turn_id,surfaceandslack_tsof thatconversation_entryrow. The surfaceAPPhas no Slack copy. -
For a Slack copy, read
slack_team_idandslack_channel_idof the main conversation. For a thread, followconversation.parent_conversation_idto the main conversation. -
If a Slack copy has no
slack_ts, find the bot reply with the Slack conversations.replies API. -
If you cannot see the provider inventory, or it is not clear, record the gap and keep the workspace paused.
Delete each copy
- Check the repository or project, the item, the provider account, the author and the text against the provider. Do not infer the object type from a numeric ID.
- Delete the copy with the provider API in the table below. Obey the rate limits of the provider.
- Read back the absence with credentials that can see the object.
A
404can mean that the object is hidden, not deleted. - After a timeout, read the object again before you retry.
- Write each feedback ID, provider reference, result, time and operator in the incident record. Include each partial failure.
| Copy | Provider API |
|---|---|
| GitHub issue or pull request comment | DELETE /repos/{owner}/{repo}/issues/comments/{comment_id} (issue comments) |
| GitHub inline review comment | DELETE /repos/{owner}/{repo}/pulls/comments/{comment_id} (review comments) |
| GitHub submitted review or approval | Not a comment. Dismiss the review (reviews), and record the text that stays. |
| GitLab issue or merge request note | DELETE /projects/:id/issues/:issue_iid/notes/:note_id or DELETE /projects/:id/merge_requests/:merge_request_iid/notes/:note_id (notes) |
| GitLab discussion or diff note | Its discussion ID and note ID (discussions) |
| Slack feedback or Hephaestus answer | chat.delete with the channel and the message ts, and a token that can delete that message (chat.delete). The answer must have ok: true. |
Outline receives no feedback. Do not delete source documents instead.
A deletion at the provider does not mark the feedback as retracted in Hephaestus. It cannot recall emails, screenshots or third-party archives.
Purge, if requested
- Check that no copy is live and that no send of the feedback is
ADMITTEDorEXECUTING. - For a purge, write the workspace ID in your restricted incident record. For a disconnect, write the workspace ID and the connection ID. After a database restore, you need them to erase again (Reapply erasures after a restore).
- Purge the workspace, disconnect the provider, or erase the person, as the request requires.
If you cannot prove step 1, keep the workspace paused and do not purge.
Check that it worked
- Run the queries of Find every copy again.
No send of the feedback is
ADMITTEDorEXECUTING. - Look up each recorded provider reference. Each copy is absent, or recorded in the incident record as kept.
Undo
A deleted provider comment cannot be restored. To send feedback again, turn Send feedback back on in the workspace, and turn off silent mode, as Contain an incident describes.